Skip to content

fix(topology): serialize enrichment table registry loads#25615

Open
pront wants to merge 1 commit into
masterfrom
codex/serialize-topology-tests
Open

fix(topology): serialize enrichment table registry loads#25615
pront wants to merge 1 commit into
masterfrom
codex/serialize-topology-tests

Conversation

@pront

@pront pront commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

Serialize access to the process-global ENRICHMENT_TABLES registry while topology builds or enrichment-table reloads move through load / finish_load.

This fixes an internal race for concurrent in-process topology builds/reloads. The normal daemon reload path already serializes reload signals through the topology controller, so this is primarily exposed by plain cargo test and test harnesses that build topologies concurrently.

Vector configuration

N/A

How did you test this PR?

  • make fmt
  • cargo test -p vector topology::test::reload --no-default-features --features sources-prometheus,sinks-prometheus,sources-internal_metrics,sources-splunk_hec,enrichment-tables-memory
  • Applied this change to fix(enrichment tables): preserve memory enrichment table state on reload #25547 and verified its previously failing reload module now passes under normal parallel cargo test
  • make check-clippy

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

None.

@github-actions github-actions Bot added the domain: topology Anything related to Vector's topology code label Jun 12, 2026
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 12, 2026
@pront pront marked this pull request as ready for review June 12, 2026 20:09
@pront pront requested a review from a team as a code owner June 12, 2026 20:09
@pront pront enabled auto-merge June 12, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: topology Anything related to Vector's topology code no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant