fix(file source): handle concatenated gzip streams#25614
Draft
thomasqueirozb wants to merge 8 commits into
Draft
fix(file source): handle concatenated gzip streams#25614thomasqueirozb wants to merge 8 commits into
thomasqueirozb wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The async file source migration (#23612, v0.50.0) replaced
flate2::bufread::MultiGzDecoderwithasync_compression::tokio::bufread::GzipDecoder.MultiGzDecoderhandles concatenated gzip streams by design;GzipDecoderstops after the first member unless.multiple_members(true)is called, which was never done. This caused the file source and fingerprinter to silently drop all but the first gzip stream in multi-member files.The fix introduces
gzip_multiple_decoderinvector-common::compression— a thin wrapper that constructs aGzipDecoderwithmultiple_membersenabled — and replaces all bareGzipDecoder::newcall sites (file watcher, fingerprinter, aws_s3 source).GzipDecoder::newis now a denied method inclippy.tomlto prevent recurrence.Vector configuration
How did you test this PR?
Create a multi-member gzip file and a standard single-member gzip file:
Run vector with the config above. Expected output (order may vary):
Before this fix,
multiple_2worldwas silently dropped becauseGzipDecoderstopped after the first member. To stress the path further, a third member was appended and all three were read correctly.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References