Cancel stale direct-access actions when filtering is disabled - #78
Open
absurd wants to merge 1 commit into
Open
Conversation
|
@absurd is attempting to deploy a commit to the varshneydevansh's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on
006a61b5(base branch checked at8501582b). Addresses the remaining timer races in #77.Disabling filtering after watch-page enforcement has queued work can still trigger a playlist click or let a retry restore the old enabled settings. For example, the player is released when Disabled is selected, but a 1300 ms retry can subsequently pass the captured enabled settings into
applyDOMFallback()and block it again.This change tracks the three delayed admission actions, cancels them when the guard is released or switches videos, and invalidates already queued callbacks with a generation counter. Before acting, callbacks check the current enabled state, blocked decision and video identity. Both retries now call
applyDOMFallback(null, ...)to use current settings. Playlist navigation resolves its allowed target again at execution time.Tests
npm run test:direct-access.git diff --check: pass.The tests execute production admission functions using controlled DOM/media and collaborator fixtures plus simulated timers. The outer fallback dispatcher is represented by an adapter. They are not full-extension/live Firefox tests.
Baseline limitations
The broader suites were run on both untouched
8501582band the patch in the same environment. They have identical failing test names and counts:These baseline failures include stale source/audit expectations and environment-dependent checks. This PR does not claim full-suite or live-browser certification and does not rewrite unrelated audit fixtures.