cache_req{,_fsm}: Add resp.storage control over synth body's storage#4358
Open
nigoroll wants to merge 1 commit intovarnishcache:masterfrom
Open
cache_req{,_fsm}: Add resp.storage control over synth body's storage#4358nigoroll wants to merge 1 commit intovarnishcache:masterfrom
nigoroll wants to merge 1 commit intovarnishcache:masterfrom
Conversation
nigoroll
force-pushed
the
sync_resp.storage
branch
from
de1b565 to
19d9528
Compare
Member
Author
|
Bugwash: Does |
nigoroll
force-pushed
the
sync_resp.storage
branch
from
19d9528 to
4585b8e
Compare
Member
Author
The answer is that we do not have a |
This adds the vcl variable resp.storage, available from vcl_synth {} to control
which storage the synth response body gets created on.
Rather than just remembering the stroage for use after VCL has returned, we
actually create an object on it when the variable changes.
This is the first step towards varnishcache#4344
nigoroll
force-pushed
the
sync_resp.storage
branch
from
4585b8e to
0766d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft PR of WIP for early review / feedback opportunities.
Next steps (planned, do not nail me down on this)
OBJ_VARATTRmore variable in length? #4359beresp.filtersVRT_l_{,be}resp_body()to write directly to the {body,vfp} without the VSB de-tourssy(synth) storage to remove last remaining memcpy forvcl_synth {}useThis adds the vcl variable resp.storage, available from vcl_synth {} to control which storage the synth response body gets created on.
Rather than just remembering the stroage for use after VCL has returned, we actually create an object on it when the variable changes.
This is the first step towards #4344