Fix for hashes in filenames, better uri encoding#1
Open
TBSliver wants to merge 2 commits intovanstyn:masterfrom
Open
Fix for hashes in filenames, better uri encoding#1TBSliver wants to merge 2 commits intovanstyn:masterfrom
TBSliver wants to merge 2 commits intovanstyn:masterfrom
Conversation
Owner
From IRC: |
Author
|
Have changed it to only percent encode specific characters ( these ones to be exact: &%#? ). more can be added quite quickly and easily in the same place as 99fbfd3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow having a hash in the filename, or something like that, caused the uri to 404 error. This fixes it, and actually encodes the outgoing uri properly. wooo!