Skip to content

feat(isNumeric): add support for thousand separator option - #2711

Open
PepiPetrov wants to merge 7 commits into
validatorjs:masterfrom
PepiPetrov:master
Open

feat(isNumeric): add support for thousand separator option#2711
PepiPetrov wants to merge 7 commits into
validatorjs:masterfrom
PepiPetrov:master

Conversation

@PepiPetrov

Copy link
Copy Markdown

This fixes #1433 and resolves merge conflicts of #1476 .

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7fdc788) to head (c0152d1).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2711   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2587      2611   +24     
  Branches       656       660    +4     
=========================================
+ Hits          2587      2611   +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PepiPetrov PepiPetrov mentioned this pull request May 18, 2026

@tux-tn tux-tn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and for taking the time to work on the old PR. I added some code recommendations in my review but I have also a general concern about the thousands_separator value. As discussed in the original PR (#1476), , I agree on limiting its value to a list of standard separators like comma, dot, space and underscore.

Comment thread src/lib/isNumeric.js Outdated
Comment thread src/lib/isNumeric.js Outdated
Comment thread README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate thousand separator is displayed for numbers

3 participants