refactor: generalize chart by removing ZTVP-specific defaults#18
Open
minmzzhang wants to merge 1 commit into
Open
refactor: generalize chart by removing ZTVP-specific defaults#18minmzzhang wants to merge 1 commit into
minmzzhang wants to merge 1 commit into
Conversation
Open
4 tasks
Remove all ZTVP-specific configuration from the chart defaults:
- Remove defaultConfig/defaultRealm (ZTVP realm, clients, users, roles, scopes)
- Remove hardcoded ExternalSecret templates for keycloak-users, qtodo OIDC,
ACS OIDC, and RHTPA OIDC secrets
- Remove oidcSecrets and users value sections
Replace with generic, consumer-driven mechanisms:
- keycloak.realms: consumers define full realm representations
- keycloak.realmPlaceholders: data-driven ${VAR} -> K8s secret mappings
for KeycloakRealmImport CRs
- keycloak.extraSecrets: generic ExternalSecret list with per-entry
lifecycle overrides, metadata, and ESO template data passthrough
Change spiffeIdentityProvider.enabled default to false (consumers opt-in).
Bump chart version to 0.1.0 (breaking change to values schema).
Regenerate README.md with helm-docs.
Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
generalize-rhbk-chart
branch
from
fdd62ca to
c9fcf9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultConfig/defaultRealm, hardcoded ExternalSecret templates,oidcSecrets, anduserssectionskeycloak.realms,keycloak.realmPlaceholders, andkeycloak.extraSecretsspiffeIdentityProvider.enableddefault tofalse(consumers opt-in)Test plan
helm lintpasseshelm templatewith defaults renders only generic infrastructurehelm templatewith test values renders all data-driven resources correctly