Fix CSI race observed on GCP - #22
Merged
Merged
Conversation
OAharoni-RedHat
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This condition was observed on GCP, but could happen in other places.
The issue is that we can create demand for DataSources before they are
ready, which effectively leads to a deadlock. These changes to the
set-default-virt-storageclass job will block argo from proceeding
with VM deployments until datasources are ready.
In non-argo uses of this chart, we already have a lot of process gates
(looking at you, ramen-family-patterns) that orchestrate quite a bit
before the VMs are deployed, so we should be OK there. We can revisit
this if it becomes an issue.