update ramendr docs to reflect change to defaults - #732
Open
OAharoni-RedHat wants to merge 1 commit into
Open
OAharoni-RedHat wants to merge 1 commit into
OAharoni-RedHat wants to merge 1 commit into
Conversation
|
🤖 Tue Sep 29 12:42:32 - The preview is ready at: |
mhjacks
requested changes
Sep 28, 2026
mhjacks
left a comment
mhjacks
left a comment
Contributor
There was a problem hiding this comment.
Really minor issue, but I'm glad it showed up, because the statement about hub/rdr/values.yaml is now obsolete and also must be changed. That's not your fault, I missed it the last time I updated docs here.
|
|
||
| . The pattern will infer the baseDomain of your cluster based on the clusterDomain which is tracked by the pattern | ||
| operator. Previously, this required the pattern to be forked to be useful - but this is no longer the case (you may | ||
| operator. Previously, this required the pattern to be forked to be useful - but this is no longer the case. you may |
Contributor
There was a problem hiding this comment.
Capitalization for "you may." Also, the link to the hub/rdr/values.yaml file is wrong - we should refer them to values-names in overrides instead I think.
Contributor
Author
There was a problem hiding this comment.
good catch, should be fixed now!
OAharoni-RedHat
force-pushed
the
main
branch
from
September 29, 2026 12:40
3a3dfa8 to
474c9fd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BYOC is now the default for RamenDR-starter-kit. We want to reflect that in our documentation.