Skip to content

improve: uses hosted default_style.json instead of manual styling#397

Draft
a-y-a-n-das wants to merge 2 commits intovalhalla:masterfrom
a-y-a-n-das:fix-use-hosted-style
Draft

improve: uses hosted default_style.json instead of manual styling#397
a-y-a-n-das wants to merge 2 commits intovalhalla:masterfrom
a-y-a-n-das:fix-use-hosted-style

Conversation

@a-y-a-n-das
Copy link
Copy Markdown
Contributor

@a-y-a-n-das a-y-a-n-das commented Mar 23, 2026

🛠️ Fixes Issue

improvement: use hosted default_style.json instead of manual styling

Closes #345

👨‍💻 Changes proposed

  • moved from manually defining layers to fetching the hosted style (default_style.json)
  • update tests to cover getValhallaStyle() & ValhallaLayersToggle

📄 Note to reviewers

  • Gsoc 2026

AI:

  • used for referencing how useMap works.
  • used for generating tests.

📷 Screenshots

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/397

@nilsnolde
Copy link
Copy Markdown
Member

nilsnolde commented Mar 23, 2026

you missed this open PR: #388. and a note that for now we won't go forward with that. I'll add a note to the issue as well.

generally look at the issue first, in the Github UI you see the timeline of everything that references an issue, including all (open) PRs.

@nilsnolde nilsnolde marked this pull request as draft March 23, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use hosted default_style.json instead of manual styling

2 participants

@a-y-a-n-das @nilsnolde