Skip to content

Bump MSRV to 1.85.1#277

Closed
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:bump_msrv
Closed

Bump MSRV to 1.85.1#277
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:bump_msrv

Conversation

@cakebaker
Copy link
Copy Markdown
Collaborator

@cakebaker cakebaker commented Apr 1, 2026

This PR bumps the MSRV from 1.71.1 to 1.74.11.85.1 because #273 introduced a (transitive) dependency that requires a MSRV of 1.74.01.85.0. It should make the CI green again.

@cakebaker cakebaker marked this pull request as draft April 1, 2026 07:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.29%. Comparing base (fe0fd40) to head (d4ac59b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          20       20           
  Lines        3847     3847           
  Branches      121      121           
=======================================
  Hits         3820     3820           
  Misses         26       26           
  Partials        1        1           
Flag Coverage Δ
macos_latest 99.29% <ø> (ø)
ubuntu_latest 99.29% <ø> (ø)
windows_latest 14.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cakebaker cakebaker changed the title Bump MSRV to 1.74.1 Bump MSRV to 1.85.1 Apr 1, 2026
@cakebaker cakebaker marked this pull request as ready for review April 1, 2026 07:20
@cakebaker cakebaker requested a review from sylvestre April 1, 2026 07:21
@cakebaker
Copy link
Copy Markdown
Collaborator Author

An alternative might be to pin the version of codspeed-criterion-compat to a version that doesn't require clap.

@cakebaker
Copy link
Copy Markdown
Collaborator Author

Closing this PR in favor of #278

@cakebaker cakebaker closed this Apr 1, 2026
@cakebaker cakebaker deleted the bump_msrv branch April 1, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant