Skip to content

add cargo dist to ship binaries - #93

Open
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:dist
Open

add cargo dist to ship binaries#93
sylvestre wants to merge 1 commit into
uutils:mainfrom
sylvestre:dist

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq

codspeed-hq Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 17 skipped benchmarks1


Comparing sylvestre:dist (7a89096) with main (b7559c4)

Open in CodSpeed

Footnotes

  1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
sylvestre requested a review from lhecker August 4, 2026 13:20

@lhecker lhecker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is from other uutils projects? I'm not sure if I'm fully qualified to review this, but it does check out.

Comment thread Cargo.toml
# The profile that 'dist' will build with
[profile.dist]
inherits = "release"
lto = "thin"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a one-time build, why not do a fat LTO?

# still allowing individual publish jobs to skip themselves (for prereleases).
# "host" however must run to completion, no skipping allowed!
if: ${{ always() && needs.host.result == 'success' }}
runs-on: "ubuntu-22.04"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty old isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants