Skip to content

diff: add --no-dereference - #327

Merged
sylvestre merged 1 commit into
diff-starting-filefrom
diff-no-dereference
Nov 3, 2026
Merged

diff: add --no-dereference#327
sylvestre merged 1 commit into
diff-starting-filefrom
diff-no-dereference

Conversation

@sylvestre

@sylvestre sylvestre commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Stack created with GitHub Stacks CLI • Give Feedback 💬

@sylvestre
sylvestre added this pull request to stack #328 October 24, 2026 13:02
@sylvestre
sylvestre marked this pull request as ready for review October 24, 2026 13:14
Copilot AI balanced review requested due to automatic review settings October 24, 2026 13:14
Copilot AI reviewed Oct 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@sylvestre
sylvestre force-pushed the diff-no-dereference branch from e4bc2f3 to 4e0a6c8 Compare October 24, 2026 20:13
Copilot AI balanced review requested due to automatic review settings October 24, 2026 20:13
Copilot AI reviewed Oct 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@sylvestre
sylvestre force-pushed the diff-no-dereference branch from 4e0a6c8 to 01149da Compare October 25, 2026 08:41
Copilot AI balanced review requested due to automatic review settings October 25, 2026 08:41
Copilot AI reviewed Oct 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@sylvestre
sylvestre force-pushed the diff-no-dereference branch from 01149da to 4c0fc76 Compare October 25, 2026 09:09
Copilot AI balanced review requested due to automatic review settings October 25, 2026 09:09
Copilot AI reviewed Oct 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@sylvestre
diff: add --no-dereference
b1a0557 
Should make test no-dereference pass.
@sylvestre
sylvestre force-pushed the diff-no-dereference branch from 4c0fc76 to b1a0557 Compare November 2, 2026 08:31
Copilot AI balanced review requested due to automatic review settings November 2, 2026 08:31
Copilot AI reviewed Nov 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

2 open issues

Review effort: Lite

Comment thread src/params.rs
Comment on lines +366 to +374
// Symbolic links that are not followed are compared like files.
let is_file = |path: &Path| {
if params.no_dereference {
path.symlink_metadata()
.is_ok_and(|metadata| !metadata.is_dir())
} else {
path.is_file()
}
};
Comment thread src/dir_diff.rs
message.extend(single_quote(target.as_encoded_bytes()));
message.extend_from_slice(separator);
}
if io::stdout().write_all(&message).is_err() {
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

GNU diffutils testsuite comparison:

Test results comparison:
  Current:   TOTAL: 33 / PASSED: 19 / FAILED: 10 / SKIPPED: 4
  Reference: TOTAL: 33 / PASSED: 8 / FAILED: 21 / SKIPPED: 4

Changes from main branch:
  TOTAL: +0
  PASSED: +11
  FAILED: -11

Test improvements (11):
  + binary
  + colliding-file-names
  + colors
  + excess-slash
  + filename-quoting
  + function-line-vs-leading-space
  + label-vs-func
  + new-file
  + no-dereference
  + starting-file
  + stdin

@sylvestre

sylvestre commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@oSoMoN can you review this stack ? ;) merci

@sylvestre
sylvestre merged commit 2c70b04 into main Nov 3, 2026
42 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre