diff: compare directories, recursively with -r by sylvestre · Pull Request #324 · uutils/diffutils

sylvestre · 2026-10-24T13:02:28Z

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Should make test excess-slash pass.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

5 open issues

operand_positions.contains(position) inside the filter makes this O(n²) in the number of CLI… · New
operand_positions.contains(position) inside the filter makes this O(n²) in the number of CLI… · New
This test depends on an external mkfifo binary being available on PATH, which can be brittle in… · New
Grammar fix: 'files that was distributed' should be 'files that were distributed'. · New
This capacity is too small in the worst case (when there are no matching names, the result can be… · New

_{Review effort: Lite}

+    // Each argument comes with its position, to tell the operands apart from
+    // an option argument with the same value.
+    let mut opts = args.iter().cloned().enumerate().peekable();
+    let mut operand_positions = Vec::new();


+    let options = args
+        .into_iter()
+        .enumerate()
+        .skip(1)
+        .filter(|(position, _)| !operand_positions.contains(position))
+        .map(|(_, arg)| arg)
+        .collect();


+        let status = std::process::Command::new("mkfifo")
+            .arg(tmp_dir.path().join(dir).join("queue"))
+            .status()?;
+        assert!(status.success());


+// This file is part of the uutils diffutils package.
+//
+// For the full copyright and license information, please view the LICENSE-*
+// files that was distributed with this source code.


+    to_names: &'a [OsString],
+    order: impl Fn(&OsStr, &OsStr) -> Ordering,
+) -> Vec<Entry<'a>> {
+    let mut entries = Vec::with_capacity(from_names.len().max(to_names.len()));


codspeed · 2026-11-02T08:54:55Z

Merging this PR will degrade performance by 8.16%

3 warnings

⚠️ 24 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 18 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 18 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 2 improved benchmarks
❌ 16 regressed benchmarks
✅ 8 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`cmd_diff_release_equal[25000]`	24.1 µs	27.7 µs	-12.97%
❌	`cmd_diff_gnu_equal[25000]`	22.8 µs	25.9 µs	-12.05%
❌	`cmd_diff_gnu_equal[10000]`	22.8 µs	25.8 µs	-11.66%
❌	`cmd_cmp_release_equal[25000]`	24.2 µs	27.2 µs	-11.03%
❌	`cmd_cmp_gnu_equal[25000]`	22.8 µs	25.6 µs	-11.03%
❌	`cmd_cmp_gnu_equal[10000]`	22.8 µs	25.6 µs	-10.81%
❌	`cmd_diff_release_equal[1000]`	24.5 µs	27.5 µs	-10.8%
❌	`cmd_diff_gnu_equal[100]`	22.4 µs	25 µs	-10.61%
❌	`cmd_diff_release_equal[10000]`	24.1 µs	26.9 µs	-10.54%
❌	`cmd_cmp_release_equal[1000]`	24.4 µs	27.3 µs	-10.43%
❌	`cmd_diff_gnu_equal[1000]`	22.5 µs	25 µs	-10.19%
❌	`cmd_cmp_release_equal[10000]`	24.6 µs	27.2 µs	-9.81%
❌	`cmd_diff_release_equal[100]`	24.4 µs	27 µs	-9.78%
❌	`cmd_cmp_gnu_equal[100]`	22.6 µs	24.4 µs	-7.34%
❌	`cmd_cmp_release_equal[100]`	25.1 µs	27.1 µs	-7.32%
❌	`cmd_cmp_gnu_equal[1000]`	22.6 µs	24.3 µs	-6.93%
⚡	`cmp_parser`	12.2 µs	10.7 µs	+13.56%
⚡	`diff_parser`	6.1 ms	5.7 ms	+6.78%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing diff-recursive (7cada7e) with diff-function-line (ba47aa3)¹}

No successful run was found on diff-function-line (8e582da) during the generation of this report, so 4e3ba6b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

github-actions · 2026-11-02T09:02:44Z

GNU diffutils testsuite comparison:

Test results comparison:
  Current:   TOTAL: 33 / PASSED: 15 / FAILED: 14 / SKIPPED: 4
  Reference: TOTAL: 33 / PASSED: 8 / FAILED: 21 / SKIPPED: 4

Changes from main branch:
  TOTAL: +0
  PASSED: +7
  FAILED: -7

Test improvements (7):
  + binary
  + colors
  + excess-slash
  + function-line-vs-leading-space
  + label-vs-func
  + new-file
  + stdin

sylvestre added this pull request to stack #328 October 24, 2026 13:02

sylvestre marked this pull request as ready for review October 24, 2026 13:14

Copilot AI balanced review requested due to automatic review settings October 24, 2026 13:14

Copilot AI reviewed Oct 24, 2026

sylvestre force-pushed the diff-recursive branch from a927245 to 36452d5 Compare October 24, 2026 20:13

Copilot AI balanced review requested due to automatic review settings October 24, 2026 20:13

Copilot AI reviewed Oct 24, 2026

sylvestre force-pushed the diff-recursive branch from 36452d5 to ab19b5e Compare October 25, 2026 08:41

Copilot AI balanced review requested due to automatic review settings October 25, 2026 08:41

Copilot AI reviewed Oct 25, 2026

sylvestre force-pushed the diff-recursive branch from ab19b5e to 2cfca73 Compare October 25, 2026 09:09

Copilot AI balanced review requested due to automatic review settings October 25, 2026 09:09

Copilot AI reviewed Oct 25, 2026

diff: compare directories, recursively with -r

7cada7e

Should make test excess-slash pass.

sylvestre force-pushed the diff-recursive branch from 2cfca73 to 7cada7e Compare November 2, 2026 08:31

Copilot AI balanced review requested due to automatic review settings November 2, 2026 08:31

Copilot started reviewing on behalf of sylvestre November 2, 2026 08:52

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

sylvestre merged commit 330ab05 into main Nov 3, 2026
41 of 47 checks passed

Navigation Menu

Repository navigation

diff: compare directories, recursively with -r - #324

diff: compare directories, recursively with -r#324
sylvestre merged 1 commit into
diff-function-linefrom
diff-recursive

sylvestre commented Oct 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sylvestre commented Oct 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

codspeed Bot commented Nov 2, 2026

Merging this PR will degrade performance by 8.16%

Performance Changes

Footnotes

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants