Breaking: Adapt coreutils dev file structure#201
Open
GunterSchmidt wants to merge 3 commits intouutils:mainfrom
Open
Breaking: Adapt coreutils dev file structure#201GunterSchmidt wants to merge 3 commits intouutils:mainfrom
GunterSchmidt wants to merge 3 commits intouutils:mainfrom
Conversation
coreutils structure. This allows more usage of the coreutils macros and is easier for the developers if working in both projects. Each utility can now be opened standalone which makes it also easier to test and benchmark. Since it is a restructure, the commit is containing a lot of files. All files were kept as much as possible and mostly the import locations were changed. Changes: * a workspace was introduced * main.rs is now /bin/diffutils.rs * uumain is now used as start of utility * all utilites have a separate folder under /uu * Exitcodes are now i32 and push to * coreutils only has License files for MIT * args are now read by using uucore::args_os() * context_diff and unified_diff now use TempDir * benches are separated for each utility and have centralized support functions Issues: * The uucore::bin! macro needs to be implemented for all main functions. Currently missing internationalization. * Tests must be run with "cargo test --workspace". * Unclear, if features can be defined globally.
Collaborator
|
very nice, thanks |
Contributor
Author
|
This is my view on what are the next steps:
So my suggestion in short: Merge #192 first, then #201. Then fix test errors and go from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapting the project structure to the coreutils structure.
coreutils uses a source code tree, which has each tool in a separate dir unter /uu,
a separate library tree and the main file under /bin. Also a number of features are
available in another directory.
Adaptiong this structure allows more usage of the coreutils macros
and methods. It makes it easier for the developers to navigate when
working in both projects.
Each utility can now be opened standalone
which makes it also easier to test and benchmark.
Since it is a file location restructure, the commit is containing
a lot of files. All files were left unchanged as much as
possible and mostly the import locations were
changed.
Changes:
uudiff (library) and the utilities uu/cmp and uu/diff.
have centralized support functions
Issues:
for all main functions. Currently missing
internationalization.