Repository navigation
od: report current offset for empty strings with --strings=0 - #16157
Merged
Merged
Conversation
cakebaker
force-pushed
the
fix/od-strings-empty-offset-16134
branch
from
November 3, 2026 08:23
423cfad to
20e09d9
Compare
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16134
Summary
When using \od --strings=0, empty strings (such as consecutive \0\ bytes) were printed with a stale \string_start_offset\ (or 0) because \string_start_offset\ is only recorded when a printable character is encountered.
This PR updates \extract_strings_from_input\ so that when \current_string.is_empty(), \current_offset\ is used as the starting offset for the null-terminated empty string, matching GNU \od\ behavior.
Verification
Added test cases in \ ests/by-util/test_od.rs\ covering:
All tests pass.