Repository navigation
factor: only skip leading spaces in number arguments - #16143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16142
GNU
factorskips only leading spaces in a number argument (then one+), and any other whitespace makes it invalid. uutils calledtrim()on every argument, sofactor '30 'andfactor $'\t30'printed factors instead of failing.This drops the
trim()and skips only leading spaces inparse_num, while the error message keeps the argument as given (' x'instead of'x'). Stdin input is already split on whitespace, so it is unchanged.Test:
test_argument_whitespace. Alltest_factortests pass, clippy and fmt are clean.Found with behave.