Repository navigation
pr: do not pad the last column of a line - #16140
Merged
Merged
Conversation
GNU pr pads a column only to line up the next one, so lines never end with spaces. Leave the last cell of a row unpadded and drop the trailing spaces from the expected test output.
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU
prpads a column only to line up the next one, so a line never ends with spaces. uutils pads every cell, including the last one:This leaves the last cell of each row unpadded. In merge mode (
-m), a file that has run out still gets its separator, as in GNU, and only the padding at the end of the line is dropped.Most of the diff is the expected test output. I stripped the trailing spaces from the content lines of eight fixture files (
column*.log.expected,mpr*.log.expected) and from the inline expectations intest_columns*andtest_merge*. Nothing else in them changed. I checked the fixture commands against GNUpr: it prints no trailing spaces in any of them, apart from the-ooffset on blank header lines (unchanged here) and the separators in merge mode.I also added
test_columns_last_column_not_padded.This came up in review of #16078.