Skip to content

stty: add mock for static binary to support bad-speed.sh - #16127

Closed
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:stty-gnu-mock
Closed

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:stty-gnu-mock

Conversation

@oech3

@oech3 oech3 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Allow running bad-speed.sh against static stty.
This is needed for rustix migration too.

@codspeed

codspeed Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

2 warnings, 1 note

⚠️ 122 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 399 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation du_wide_tree[(5000, 500)] 15.1 ms 15.7 ms -3.87%
⚡ Memory du_deep_tree[(100, 3)] 82.4 KB 76.5 KB +7.68%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:stty-gnu-mock (d7aa975) with main (43eb620)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@xtqqczze

xtqqczze commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Why do we return ENOSPC ("No space left on device") when LD_PRELOAD environment variable is set and contains k.so?

@oech3

oech3 commented Nov 2, 2026 via email

Copy link
Copy Markdown
Contributor Author

@oech3
oech3 force-pushed the stty-gnu-mock branch 2 times, most recently from d9c15a0 to d7aa975 Compare November 2, 2026 12:41
@sylvestre

Copy link
Copy Markdown
Contributor

sorry but i don't want test-specific code in stty that fakes the result of bad-speed.sh
if the test can't work with a static binary, let's skip it with a patch in util/gnu-patches instead

@sylvestre sylvestre closed this Nov 3, 2026
@oech3

oech3 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

No. Patch is impossible in this case.

@oech3
oech3 deleted the stty-gnu-mock branch November 3, 2026 11:49
@oech3

oech3 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

I did this since you did not hope to skip the test at #15299 .
It is possible to supress vervosity in the main code by separating fn and put it under test code (I updated #15299 to do that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants