Skip to content

stty: remove an unnecessary allocation - #16100

Merged
RenjiSann merged 1 commit into
uutils:mainfrom
oech3:stty-vec
Nov 2, 2026
Merged

stty: remove an unnecessary allocation#16100
RenjiSann merged 1 commit into
uutils:mainfrom
oech3:stty-vec

Conversation

@oech3

@oech3 oech3 commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • remove unnecessary heap(Vec) alloc.
  • Alloc u8 if u32 is overlill.
  • Drop unnecessary check.

@oech3
oech3 force-pushed the stty-vec branch 2 times, most recently from a1bf8d7 to 41a4312 Compare November 1, 2026 06:14
@oech3 oech3 changed the title stty: remove an unnecessary heap allocation stty: remove an unnecessary allocation Nov 1, 2026
@oech3
oech3 marked this pull request as ready for review November 1, 2026 06:56
@oech3
oech3 force-pushed the stty-vec branch 5 times, most recently from 08dd04d to c753724 Compare November 1, 2026 07:59
oech3
oech3 commented Nov 1, 2026
View reviewed changes
Comment thread src/uu/stty/src/stty.rs Resolved
RenjiSann
RenjiSann reviewed Nov 2, 2026
View reviewed changes
Comment thread src/uu/stty/src/stty.rs Resolved
Comment thread src/uu/stty/src/stty.rs Resolved
Comment thread src/uu/stty/src/stty.rs Resolved
Comment thread src/uu/stty/src/stty.rs Resolved
Comment thread src/uu/stty/src/stty.rs Resolved
@oech3
oech3 requested a review from RenjiSann November 2, 2026 12:38
@RenjiSann
RenjiSann merged commit 19f6602 into uutils:main Nov 2, 2026
97 checks passed
@RenjiSann

RenjiSann commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

thanks !

@oech3
oech3 deleted the stty-vec branch November 2, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RenjiSann RenjiSann Awaiting requested review from RenjiSann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @RenjiSann