[lunatic1hero]

Fixes #15814

apply_xattrs_fd_ignore_unsupported() stopped at the first xattr the
destination refused with ENOTSUP and returned Ok(()). In a cross-device
directory move, this meant system.posix_acl_access was never applied
if a user.* attribute was tried first, so the ACL was silently dropped.

This changes the helper to iterate the attributes, skip only the
unsupported ones, and still return the first other error.

I used an AI assistant for guidance on the contribution workflow; I
applied and reviewed the change myself.

[codspeed]

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 122 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks¹

---

_{Comparing lunatic1hero:fix-mv-xattr-acl-drop (59fd00c) with main (8e267ce)}

Footnotes

1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sylvestre]

please add a test, a unit test here is enough:
an unknown namespace like foo.x gets EOPNOTSUPP from the kernel, so apply it with a few user.* and check those are set

[lunatic1hero]

done

[sylvestre]

the doc comment above still says it maps ENOTSUP to Ok(()), please update it to say it skips the unsupported attributes

[lunatic1hero]

done

[sylvestre]

res => res? reads a bit odd, Err(e) => return Err(e), Ok(()) => {} is clearer, no?

[lunatic1hero]

Will do it for sure pc under repair, iam new to opensrc any suggestions?

…

On Fri, 30 Oct, 2026, 11:21 pm Sylvestre Ledru, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/uucore/src/lib/features/fsxattr.rs <#16052 (comment)>: > @@ -241,10 +241,14 @@ pub fn apply_xattrs_fd_ignore_unsupported( dest: &std::fs::File, xattrs: FxHashMap<OsString, Vec<u8>>, ) -> std::io::Result<()> { - match apply_xattrs_fd(dest, xattrs) { - Err(e) if is_xattr_unsupported(&e) => Ok(()), - res => res, + use xattr::FileExt; + for (attr, value) in xattrs { + match dest.set_xattr(&attr, &value) { + Err(e) if is_xattr_unsupported(&e) => {} + res => res?, res => res? reads a bit odd, Err(e) => return Err(e), Ok(()) => {} is clearer, no? — Reply to this email directly, view it on GitHub <#16052?email_source=notifications&email_token=BAIPFEZI3SHEDPA4IU7PABT5WTIK3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKNZRGYZTSMRVGU3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5716392556>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BAIPFE6TDS4UPDSN5H7WZT35WTIK3AVCNFSNUABEKJSXA33TNF2G64TZHMYTCOBUG42TAMB3JFZXG5LFHM3DCMJWGA4TSMZRGGQXMAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[sylvestre]

thanks for this PR!
the fix looks right, but it still needs the unit test (unsupported foo.x next to a few user.*) and the doc comment update from the earlier review before it can land.

[lunatic1hero]

thanks for this PR! the fix looks right, but it still needs the unit test (unsupported foo.x next to a few user.*) and the doc comment update from the earlier review before it can land.

sorry for the delay, had made the required changes before only, but was facing issues writing the test , as this is my first contribution, open for suggestions.