Repository navigation
Conversation
|
GNU testsuite comparison: |
Logic769
force-pushed
the
od-final-offset-on-error
branch
2 times, most recently
from
October 30, 2026 13:02
288df47 to
6bd068f
Compare
Logic769
force-pushed
the
od-final-offset-on-error
branch
2 times, most recently
from
November 1, 2026 14:41
5f25921 to
ccb9d66
Compare
sylvestre
reviewed
Nov 2, 2026
sylvestre
reviewed
Nov 2, 2026
Track whether any input was opened so that a directory, which can be opened but not read, still gets its final offset printed like GNU. Tighten the failing-input test to the exact output and cover od d alone and od missing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When one of the od inputs could not be read, the final offset line was omitted. GNU still prints it after the error.
Change
Always write the final offset when the input ends or fails, and add a regression test using a directory as an input.
Closes #15990