Repository navigation
Conversation
RenjiSann
force-pushed
the
od-strings-type-conflict
branch
from
October 30, 2026 10:36
413efdb to
d5e22c4
Compare
Logic769
force-pushed
the
od-strings-type-conflict
branch
2 times, most recently
from
November 1, 2026 14:41
109b848 to
5f25921
Compare
Devel08
reviewed
Nov 1, 2026
Contributor
|
a bunch of jobs are failing |
Logic769
force-pushed
the
od-strings-type-conflict
branch
from
November 2, 2026 01:02
5f25921 to
164e1d8
Compare
sylvestre
reviewed
Nov 2, 2026
sylvestre
reviewed
Nov 2, 2026
sylvestre
reviewed
Nov 2, 2026
Logic769
force-pushed
the
od-strings-type-conflict
branch
from
November 3, 2026 15:43
2d631d2 to
2d93634
Compare
Logic769
force-pushed
the
od-strings-type-conflict
branch
from
November 3, 2026 15:54
2d93634 to
31e10e2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
od --strings=1 -c a.txtprints strings and exits 0, whereas GNU od rejects a type option together with--strings:The same happens with
-b,-d,-i,-l,-o,-s,-x,-tand the other traditional format flags.Change
Add
has_type_option()inparse_formats(mirrorsparse_format_flags) and reject the combination when--stringsis given, with exit code 1 and the GNU message.Tests
Added
test_strings_with_type_option_is_errorintests/by-util/test_od.rs.Closes #15989