[Logic769]

Problem

sort -o out --debug succeeds, writes out and prints its debug notes, whereas GNU sort rejects this combination:

sort: options '-o --debug' are incompatible
(exit code 2)

Change

Reject the combination of -o/--output and --debug before any output is written, with exit code 2.

Tests

Added test_debug_incompatible_with_output in tests/by-util/test_sort.rs, which checks the exit code, the error message and that no output file is created.

Closes #15998

[Logic769]

Moved the check next to the -co one and used incompatible_options_error("o --debug"), so the ftl string and the variant are gone. The test asserts fails_with_code(2) and stderr_only("sort: options '-o --debug' are incompatible\n").

[codspeed]

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 29 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 58 untouched benchmarks
⏩ 414 skipped benchmarks¹

---

_{Comparing Logic769:sort-debug-output-incompatible (d9dddef) with main (c5ce288)²}

Footnotes

1. 414 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (36a00ef) during the generation of this report, so c5ce288 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[sylvestre]

lot of jobs are failing
please monitor this for all your PR

[sylvestre]

a bunch of jobs are failing