Repository navigation
Conversation
Logic769
force-pushed
the
split-plus-number
branch
from
October 30, 2026 13:03
589fc05 to
7117f76
Compare
sylvestre
reviewed
Oct 30, 2026
sylvestre
reviewed
Oct 30, 2026
sylvestre
reviewed
Oct 30, 2026
Logic769
force-pushed
the
split-plus-number
branch
from
October 31, 2026 01:52
7117f76 to
80c864d
Compare
Contributor
Author
|
Pulled the |
Logic769
force-pushed
the
split-plus-number
branch
from
November 2, 2026 01:02
80c864d to
d806318
Compare
sylvestre
reviewed
Nov 2, 2026
Contributor
|
a bunch of jobs are failing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
split -n +2 filefails with "invalid number of chunks" because the leading+is not stripped before parsing, whereas GNUsplitaccepts it.Change
In
NumberType::from, strip an optional leading+before parsing the chunk count.Tests
Added
test_number_with_plus_prefixintests/by-util/test_split.rs, checking that-n +2splits the file into two chunks.Closes #16006