Skip to content

join: let --nocheck-order after --check-order win - #16013

Merged
cakebaker merged 2 commits into
uutils:mainfrom
Logic769:join-last-of-check-order-wins
Nov 2, 2026
Merged

cakebaker merged 2 commits into
uutils:mainfrom
Logic769:join-last-of-check-order-wins

Conversation

@Logic769

@Logic769 Logic769 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

GNU join lets the last of --check-order and --nocheck-order win, so join --check-order --nocheck-order a.txt a.txt disables the order check and exits 0. uutils always let --check-order win and reported the input as unsorted.

This makes the two options mutually override so the last one on the command line wins, matching GNU.

Adds a regression test.

Closes #16004

@Logic769
Logic769 force-pushed the join-last-of-check-order-wins branch from e430b50 to c5a5b60 Compare October 30, 2026 13:03
Comment thread tests/by-util/test_join.rs Resolved
@Logic769

Copy link
Copy Markdown
Contributor Author

Added a test for --nocheck-order --check-order: the later --check-order still reports the unsorted input as join: a.txt:2: is not sorted: a, which is what GNU does.

@cakebaker
cakebaker force-pushed the join-last-of-check-order-wins branch from a1f94be to af51ec4 Compare November 1, 2026 15:45
@cakebaker
cakebaker merged commit e4c6038 into uutils:main Nov 2, 2026
100 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

join: --nocheck-order after --check-order should win

3 participants