[fixfon]

Fixes #15810

In the shell-escape styles, a name that has an apostrophe and a C1 control character (U+0080 to U+009F) was printed as one double-quoted word that contains a $'\302\233' segment. A shell does not expand $'...' inside double quotes, so the word named a different file. For it's followed by U+009B and here, printf %q printed "it's'$'\302\233''here". ls --quoting-style=shell-escape, ls --quoting-style=shell-escape-always and stat -c %N printed the same word.

EscapedShellQuoter::new switches to single quotes when the name is not valid in the locale encoding, because only then did it expect a $'...' segment. A valid C1 character is also written that way, so the check missed it. The check now asks EscapedChar::new_shell, which writes the segment, so the two cannot drift apart. The word is now 'it'\''s'$'\302\233''here'.

I added a unit test in quoting_style and a printf %q test in test_printf.rs. Both fail on current main and pass with this change. cargo fmt passes, cargo clippy --all-targets -- -D warnings passes, and the uucore tests and test_ls, test_printf and test_stat pass, except test_ls_indicator_style, which fails the same way on main in my setup because of a long socket path on macOS. Tested on macOS only.

[sylvestre]

maybe also add a ls --quoting-style=shell-escape test? the issue reports it there too

[fixfon]

Added a test_ls case for shell-escape with a C1 control and an apostrophe, in b6e2ce3.

[codspeed]

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 123 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks¹

---

_{Comparing fixfon:fix/15810-c1-control-apostrophe (b5498cf) with main (9cc868b)²}

Footnotes

1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (ddc71a4) during the generation of this report, so 9cc868b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[sylvestre]

Thanks for your PR