Skip to content

build: use shared bsd cfg alias - #15634

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:refactor/cfg_aliases/bsd
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:refactor/cfg_aliases/bsd

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Use a shared cfg alias for BSD targets to reduce duplication and keep platform-specific conditional compilation consistent across the codebase.

Closes #15423.
Closes #15425.
Follow-up to #10443.

@oech3

This comment was marked as resolved.

@codspeed

codspeed Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 2 benchmarks

1 warning, 1 note

⚠️ 121 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 398 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation sort_numeric_utf8_locale 35.8 ms 37.1 ms -3.67%
❌ CPU Simulation sort_reverse_utf8_locale 79.1 ms 81.9 ms -3.48%
⚡ Memory du_deep_tree[(100, 3)] 82.4 KB 76.5 KB +7.68%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:refactor/cfg_aliases/bsd (f94f62a) with main (6201c4f)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (00c3626) during the generation of this report, so 6201c4f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze marked this pull request as ready for review October 22, 2026 20:07
@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch 2 times, most recently from 9d4a68e to 8b0ebf8 Compare October 22, 2026 20:26
@xtqqczze
xtqqczze requested a review from sylvestre October 22, 2026 23:07
@xtqqczze
xtqqczze requested a review from cakebaker October 23, 2026 15:05
@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from 8b0ebf8 to 4024f85 Compare October 25, 2026 12:15
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

@sylvestre ready

@oech3

oech3 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This is maintainer's decision, but it would be nice if #15299 was merged at 1st which was reciently rebased by maintainer.

@xtqqczze
xtqqczze force-pushed the refactor/cfg_aliases/bsd branch 2 times, most recently from 1c76ded to f989cb7 Compare October 31, 2026 10:56
@sylvestre
sylvestre force-pushed the refactor/cfg_aliases/bsd branch from f989cb7 to f94f62a Compare November 2, 2026 21:15
@xtqqczze

xtqqczze commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

Check failures tracked by #16147.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_stty.rs: Support bsd cfg_aliases

2 participants