Skip to content

refactor: replace rustix::process dependency with rlimit - #14739

Merged
sylvestre merged 2 commits into
uutils:mainfrom
xtqqczze:GH14664
Oct 25, 2026
Merged

sylvestre merged 2 commits into
uutils:mainfrom
xtqqczze:GH14664

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #14914.
Relates to #14664.

Required to compile uutests and enables the fd_soft_limit code path in uu_sort for Redox targets.

@sylvestre

Copy link
Copy Markdown
Contributor

sorry but i am not going to revert anything until we have a CI running for redox

@oech3

oech3 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

I think we don't need to revert this since we were not running test(impossible?) for Redox on the CI previously.

@sylvestre sylvestre closed this Sep 20, 2026
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

I think we should add a check-only job at the very least:

cargo check --all-targets --features feat_os_unix_redox --target x86_64-unknown-redox

We can set continue-on-error: true for now so that any existing errors don’t block CI, while still giving us visibility into Redox build issues.

@sylvestre

Copy link
Copy Markdown
Contributor

Sounds good

@xtqqczze

This comment was marked as outdated.

@oech3

oech3 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Do we really need to hurry supporting test on redox? Most logic are shared with other platforms.

@xtqqczze xtqqczze reopened this Sep 28, 2026
@xtqqczze
xtqqczze marked this pull request as draft September 28, 2026 15:21
@xtqqczze
xtqqczze force-pushed the GH14664 branch 2 times, most recently from d2139df to e8df3ba Compare September 28, 2026 16:19
@xtqqczze xtqqczze self-assigned this Sep 28, 2026
@codspeed

codspeed Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 120 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks1


Comparing xtqqczze:GH14664 (c415bfc) with main (18bc31f)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@xtqqczze xtqqczze closed this Sep 28, 2026
@xtqqczze xtqqczze reopened this Oct 11, 2026
@xtqqczze xtqqczze changed the title Revert "tests: replace rlimit dependency with rustix::process" refactor: replace rustix::process dependency with rlimit Oct 11, 2026
@xtqqczze
xtqqczze force-pushed the GH14664 branch 3 times, most recently from 5787bfb to 5489611 Compare October 11, 2026 16:48
@oech3

oech3 commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

If we replaced rustix with rlimit, we need large diff again to remove it after rustix supported rlimit on redox.

@xtqqczze
xtqqczze force-pushed the GH14664 branch 6 times, most recently from 546552d to d71ebe6 Compare October 13, 2026 12:56
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

Split the uutests changes to #14252.

@xtqqczze xtqqczze closed this Oct 13, 2026
@xtqqczze

Copy link
Copy Markdown
Collaborator Author

If we replaced rustix with rlimit, we need large diff again to remove it after rustix supported rlimit on redox.

rustix doesn't seem to be actively maintained. Perhaps we should consider forking it.

@oech3

oech3 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Is there any collaborator for rustix repo in ? We should consider asking maintainer to add collaborator from bytecodealliance.

@oech3

oech3 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Since their famous project (e.g. wasmtime) depends on rustix, I think they cannot abandon it.

@xtqqczze xtqqczze reopened this Oct 14, 2026
@xtqqczze
xtqqczze force-pushed the GH14664 branch 7 times, most recently from d861d13 to f8a0e4b Compare October 20, 2026 18:25
@xtqqczze
xtqqczze marked this pull request as ready for review October 24, 2026 13:08
@xtqqczze
xtqqczze requested a review from sylvestre October 24, 2026 13:08
@sylvestre
sylvestre merged commit ff0c589 into uutils:main Oct 25, 2026
194 checks passed
@sylvestre

Copy link
Copy Markdown
Contributor

Thanks for your PR

@xtqqczze
xtqqczze deleted the GH14664 branch October 25, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustix does not support rlimit on Redox

3 participants