Skip to content

cp: remove dep on filetime crate - #14687

Draft
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cp-filetime
Draft

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:cp-filetime

Conversation

@oech3

@oech3 oech3 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed

codspeed Bot commented Sep 18, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 7.62%

⚡ 2 improved benchmarks
✅ 365 untouched benchmarks
⏩ 50 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cp_archive_balanced_tree[(5, 4, 10)] 109.5 ms 101.3 ms +8%
Simulation cp_preserve_metadata[(5, 4, 10)] 101 ms 94.2 ms +7.24%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:cp-filetime (d3f3e77) with main (58bc4fa)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
oech3 force-pushed the cp-filetime branch 3 times, most recently from 22924c5 to d3f3e77 Compare September 18, 2026 18:00
Comment thread src/uu/cp/src/cp.rs

@xtqqczze xtqqczze Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to implement for cfg(target_os = "wasi")

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/cp/attr-existing. tests/cp/attr-existing is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/backup-dir. tests/cp/backup-dir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/cp-a-selinux. tests/cp/cp-a-selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/cp-parents. tests/cp/cp-parents is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/link-heap. tests/cp/link-heap is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/link-symlink. tests/cp/link-symlink is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/parent-perm. tests/cp/parent-perm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/perm. tests/cp/perm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-link. tests/cp/preserve-link is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/preserve-slink-time. tests/cp/preserve-slink-time is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/readonly-dir. tests/cp/readonly-dir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/src-base-dot. tests/cp/src-base-dot is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/selinux. tests/misc/selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/dup-source. tests/mv/dup-source is passing on 'main'. Maybe you have to rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants