Skip to content

dd: replace gcd dependency with num-integer - #14663

Merged
cakebaker merged 1 commit into
uutils:mainfrom
wtcpython:dd-replace-gcd
Sep 18, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
wtcpython:dd-replace-gcd

Conversation

@wtcpython

@wtcpython wtcpython commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

num-integer is already in our dependency tree; using it drops the standalone gcd crate while keeping the same behavior.

Copilot AI lite review requested due to automatic review settings September 18, 2026 07:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sylvestre

Copy link
Copy Markdown
Contributor

Please document the why

@wtcpython wtcpython closed this Sep 18, 2026
@wtcpython wtcpython reopened this Sep 18, 2026
@oech3

oech3 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

I think it is already transitive dep.

@wtcpython

Copy link
Copy Markdown
Contributor Author

num-integer is already in our dependency tree; using it drops the standalone gcd crate while keeping the same behavior.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@cakebaker
cakebaker merged commit 4cba2db into uutils:main Sep 18, 2026
343 of 350 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@wtcpython
wtcpython deleted the dd-replace-gcd branch September 18, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants