Conversation
|
GNU testsuite comparison: |
krosci
force-pushed
the
mv-fchown-cross-device
branch
from
September 17, 2026 11:06
d9a2a1a to
376f213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename_file_fallbackkept the destination descriptor across the copy butpreserve_ownershipre-resolved the destination by path and calledlchown, so a concurrent path-swap could redirect the chown to another inode. The comment above the block claimed a guarantee the code did not provide.The cross-device leaf now chowns through the descriptor it already holds with
fchown, and the destination is created withO_EXCL, matching GNU.create_dest_restrictivegains anexclusiveflag, whilecpkeeps truncating a pre-existing destination.Fixes #14599.