Skip to content

install: gate by target support - #14586

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:gate-install
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:gate-install

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

install: gate by target support

Gate install to Unix targets.

install now builds successfully with Clippy on AIX, Hurd, and Redox:

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std -p uu_install --all-features --all-targets --target powerpc64-ibm-aix --target x86_64-unknown-hurd-gnu --target x86_64-unknown-redox

@sylvestre

Copy link
Copy Markdown
Contributor

This is quite intrusive for niche archs / os

@xtqqczze

Copy link
Copy Markdown
Contributor Author

@sylvestre You did raise this exact issue in #14537, though. The changes are mostly just amending the existing cfg conditions.

@xtqqczze xtqqczze changed the title install: avoid safe_traversal on unsupported platforms install: gate by target support Sep 15, 2026
@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze force-pushed the gate-install branch 3 times, most recently from 108789c to 4be3480 Compare September 15, 2026 21:57
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is now passing!
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@xtqqczze

xtqqczze commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

This is quite intrusive for niche archs / os

Since we don't build on Windows or WASI, I gated install to Unix which simplified the conditions.

@xtqqczze
xtqqczze marked this pull request as ready for review September 15, 2026 23:10
Gate `install` to Unix targets.

`install` now builds successfully with Clippy on AIX, Hurd, and Redox:

```sh
RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std -p uu_install --all-features --all-targets --target powerpc64-ibm-aix --target x86_64-unknown-hurd-gnu --target x86_64-unknown-redox
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants