Prepare version 0.12.0 - #14578
Prepare version 0.12.0#14578
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for the updater and clarify its header description.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prepares the repository for the 0.12.0 release while making version updates safer for third-party dependencies.
Changes:
- Updates workspace, crate, dependency, and lockfile versions.
- Narrows version-update automation to in-tree dependencies.
- Adds checks for remaining old versions.
File summaries
| File | Description |
|---|---|
util/update-version.sh |
Refines release automation. Moderate: add regression coverage; nit: update the header description. |
src/uu/stdbuf/Cargo.toml |
Updates the libstdbuf dependency version. |
fuzz/uufuzz/Cargo.toml |
Updates fuzz crate versions. |
fuzz/Cargo.lock |
Refreshes fuzz workspace versions. |
Cargo.toml |
Updates workspace and crate versions. |
Cargo.lock |
Refreshes workspace package versions. |
Review details
Suppressed comments (1)
util/update-version.sh:29
- The header at lines 4–5 still says this helper mass-replaces all versions, but this change intentionally preserves third-party versions. Update that description so release maintainers are not misled about what the script rewrites.
# Only two kinds of lines are rewritten, so that third party crates which
# happen to share our version number (md-5, sha1, sha2, sha3, ...) are left
# alone:
# 1) the crate's own version declaration, anchored at the start of the line
# 2) dependencies carrying a "path =" key, which are the in-tree uutils crates
- Files reviewed: 4/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # 2) the in-tree dependencies, keeping the ">=" prefix when there is one | ||
| #shellcheck disable=SC2086 | ||
| sed -i -e "s|uucore_procs = { version=\">=$FROM\",|uucore_procs = { version=\">=$TO\",|" $PROGS | ||
| sed -i -E "/path *=/ s|(version *= *\"(>=)?)$FROM\"|\1$TO\"|g" $MANIFESTS |
|
GNU testsuite comparison: |
|
|
||
| FROM="0.10.0" | ||
| TO="0.11.0" | ||
| FROM="0.11.0" |
There was a problem hiding this comment.
| FROM="0.11.0" | |
| FROM=$(cargo tree -p coreutils |head -n 1|sed -e "s/coreutils v//" -e "s/ (.*//") |
|
@sylvestre It would be great if you could give |
|
Would you do #13839 (comment) before new release to test publishing process before 0.12.0? |
|
No description provided.