fix(wasi): sort ordering check and external-merge separator - #13688
Open
eduardomourar wants to merge 1 commit into
Open
fix(wasi): sort ordering check and external-merge separator#13688eduardomourar wants to merge 1 commit into
eduardomourar wants to merge 1 commit into
Conversation
eduardomourar
force-pushed
the
wasi-sort-fixes
branch
from
August 1, 2026 11:44
362b58c to
e7e30d4
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
eduardomourar
force-pushed
the
wasi-sort-fixes
branch
from
August 1, 2026 12:46
e7e30d4 to
bd72c05
Compare
sort's ordering check runs single-threaded on WASI, which has no thread support, reading every chunk up front instead of streaming from a background reader thread. Its external-merge path also inserts a missing separator between concatenated files so lines don't merge across file boundaries.
eduardomourar
force-pushed
the
wasi-sort-fixes
branch
from
August 1, 2026 22:45
bd72c05 to
62496f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort's ordering check runs single-threaded on WASI, which has no thread support, reading every chunk up front instead of streaming from a background reader thread. Its external-merge path also inserts a missing separator between concatenated files so lines don't merge across file boundaries.