fix(wasi): cp attribute preservation and symlink handling - #13685
Open
eduardomourar wants to merge 1 commit into
Open
fix(wasi): cp attribute preservation and symlink handling#13685eduardomourar wants to merge 1 commit into
eduardomourar wants to merge 1 commit into
Conversation
|
GNU testsuite comparison: |
sylvestre
reviewed
Aug 1, 2026
eduardomourar
force-pushed
the
wasi-cp-fixes
branch
from
August 1, 2026 12:39
9c9ce6c to
6dc0718
Compare
cp treats ENOSYS like EOPNOTSUPP when skipping optional attribute preservation (WASI has no chmod/chown at all), reads timestamps via Metadata::accessed/modified instead of the filetime crate (which panics there), creates symlinks via rustix::fs::symlink, and only errors out of --reflink when explicitly requested rather than whenever it isn't Never.
eduardomourar
force-pushed
the
wasi-cp-fixes
branch
from
August 1, 2026 14:28
6dc0718 to
c0a4356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp treats ENOSYS like EOPNOTSUPP when skipping optional attribute preservation (WASI has no chmod/chown at all), reads timestamps via Metadata::accessed/modified instead of the filetime crate (which panics there), creates symlinks via rustix::fs::symlink, and only errors out of --reflink when explicitly requested rather than whenever it isn't Never.