Skip to content

uucore: translate! UIoError error messages, reduce error message duplication - #13680

Draft
RenjiSann wants to merge 2 commits into
uutils:mainfrom
RenjiSann:l10n-uioerror
Draft

uucore: translate! UIoError error messages, reduce error message duplication#13680
RenjiSann wants to merge 2 commits into
uutils:mainfrom
RenjiSann:l10n-uioerror

Conversation

@RenjiSann

Copy link
Copy Markdown
Collaborator

This is an attempt to fix #11451

@codspeed-hq

codspeed-hq Bot commented Jul 31, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 8.25%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 31 regressed benchmarks
✅ 308 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation complex_relative_date 314 µs 438.9 µs -28.47%
Memory factor_multiple_u64s[2] 54.1 KB 65.5 KB -17.43%
Memory hostname_basic 56.3 KB 67.7 KB -16.86%
Memory seq_custom_separator 58.4 KB 69.8 KB -16.34%
Memory wc_lines_extreme_line_lengths[(100000, 200)] 65.1 KB 76.5 KB -14.92%
Memory nl_many_lines[100000] 66.2 KB 77.6 KB -14.71%
Memory unexpand_many_lines[100000] 67 KB 78.4 KB -14.56%
Memory expand_custom_tabstops[50000] 67 KB 78.4 KB -14.55%
Memory cut_fields_newline_delim 69.3 KB 80.7 KB -14.14%
Memory fold_custom_width[50000] 76.1 KB 87.5 KB -13.05%
Memory split_numeric_suffix 80.5 KB 91.9 KB -12.41%
Memory df_deep_directory 80.7 KB 92.1 KB -12.38%
Memory join_custom_separator 86 KB 97.4 KB -11.71%
Memory cksum_multiple_files 91.2 KB 102.6 KB -11.12%
Memory tee_stdin_file[10000000] 69.7 KB 78 KB -10.7%
Memory rm_recursive_tree 98 KB 109.4 KB -10.43%
Simulation hostname_basic 331.3 µs 367.4 µs -9.82%
Memory timer_expiry_latency[0.001] 79.9 KB 88.2 KB -9.46%
Memory cat_default[10000] 81.4 KB 89.7 KB -9.3%
Simulation tee_stdin_file[10000000] 368.3 µs 400 µs -7.91%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing RenjiSann:l10n-uioerror (0420d11) with main (d99a177)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

Well, that's some nasty performance regression

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/du/files0-from. tests/du/files0-from is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/du/inacc-dest. tests/du/inacc-dest is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/du/no-x. tests/du/no-x is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

For some reason I don't get, translate!() in uucore in the du binary is broken 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UIoError messages are not translated

1 participant