Skip to content

split: restore --io-blocksize & remove io::copy - #13643

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:split-del-copy
Open

split: restore --io-blocksize & remove io::copy#13643
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:split-del-copy

Conversation

@oech3

@oech3 oech3 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Needed to distinct read/write error in the future and support reflink and zero-copy.

@codspeed-hq

codspeed-hq Bot commented Jul 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:split-del-copy (4df1546) with main (f258a3f)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze

This comment was marked as off-topic.

@oech3

oech3 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

In the case buffering is not allowed and block size is given, we cannot use Buf{Reader, Writer} in io::copy even reader's error message is hacked to distinct.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants