Skip to content

Kill: Display error on invalid UTF-8 rather than list of signals #12878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iburaky2 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Open

Kill: Display error on invalid UTF-8 rather than list of signals #12878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d444988
kill: Continue processing invalid UTF-8 arguments to match GNU behaviour
iburaky2 Jun 14, 2026
1e33f1a
tests/kill: Test supplying invalid UTF-8 argument to kill
iburaky2 Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/uu/kill/src/kill.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pub enum Mode {

#[uucore::main]
pub fn uumain(args: impl uucore::Args) -> UResult<()> {
let mut args = args.collect_ignore();
let mut args = args.collect_lossy();
let obs_signal = handle_obsolete(&mut args);

let matches = uucore::clap_localization::handle_clap_result(uu_app(), args)?;
Expand Down
14 changes: 13 additions & 1 deletion tests/by-util/test_kill.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.
// spell-checker:ignore IAMNOTASIGNAL RTMAX RTMIN SIGRTMAX
// spell-checker:ignore IAMNOTASIGNAL RTMAX RTMIN SIGRTMAX FFFD
use regex::Regex;
use std::os::unix::process::ExitStatusExt;
use std::process::{Child, Command};
Expand Down Expand Up @@ -539,3 +539,15 @@ fn test_kill_realtime_signal() {
.succeeds();
assert_eq!(target.wait_for_signal(), Some(libc::SIGRTMIN()));
}

#[test]
fn test_kill_invalid_utf8() {
let arg = uucore::os_str_from_bytes(b"\xFFa\xFF")
.expect("Only unix platforms can test non-unicode names");

new_ucmd!()
.arg("-l")
.arg(&arg)
.fails()
.stderr_contains("'\u{FFFD}a\u{FFFD}': invalid signal");
}
Loading