Skip to content

yes: catch strace injection with slow stdout #12834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oech3 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

yes: catch strace injection with slow stdout #12834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/uu/yes/src/yes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,19 @@ pub fn exec(bytes: &[u8]) -> io::Result<()> {
&& p_write.write_all(bytes).is_ok()
&& let Ok((broker_read, broker_write)) = pipe::<true>()
&& Ok(bytes_len) == tee(&p_read, &broker_write, MAX_ROOTLESS_PIPE_SIZE)
&& uucore::pipes::drain_pipe(&broker_read, &stdout, bytes_len)?.is_ok()
&& let Ok(drained) = splice(&broker_read, &stdout, bytes_len)
{
// fallback from tee() is possible since we did not send anything to stdout yet
while let Ok(mut remain) = tee(&p_read, &broker_write, MAX_ROOTLESS_PIPE_SIZE) {
debug_assert!(remain == bytes_len, "splice should cleanup pipe");
let mut remain = bytes_len - drained;
'splice: loop {
while remain > 0 {
remain -= splice(&broker_read, &stdout, remain)?;
}
// fallback from tee() is possible since we did not send anything to stdout yet
let Ok(tee_len) = tee(&p_read, &broker_write, MAX_ROOTLESS_PIPE_SIZE) else {
break 'splice;
};
debug_assert!(tee_len == bytes_len, "splice should cleanup pipe");
remain = tee_len;
}
}

Expand Down
Loading