Skip to content

chmod: modified no-op errors for parity with gnu#12748

Open
max-amb wants to merge 6 commits into
uutils:mainfrom
max-amb:chmod_no_op
Open

chmod: modified no-op errors for parity with gnu#12748
max-amb wants to merge 6 commits into
uutils:mainfrom
max-amb:chmod_no_op

Conversation

@max-amb

@max-amb max-amb commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Part of #12584, fixes chmod/only-op.sh.

@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 323 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing max-amb:chmod_no_op (f487d87) with main (eee005a)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout-group (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/chmod/only-op is no longer failing!
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

Comment thread src/uu/chmod/src/chmod.rs
if !self.quiet {
show_error!("{err}");
show_error!(
"changing permissions of {}: {}",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be translatable

@sylvestre

Copy link
Copy Markdown
Contributor

please add a rust test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants