Chore: Improve canonical email test for proton case insensitive mails#20
Chore: Improve canonical email test for proton case insensitive mails#20Meldiron wants to merge 1 commit into
Conversation
Greptile SummaryThis PR adds test cases to cover case-insensitive canonicalisation of ProtonMail addresses, specifically verifying that mixed- and upper-case local parts are lowercased and that
Confidence Score: 4/5Safe to merge; all changes are test-only additions with no production code impact. The only change is in test files, and the tests themselves are correct — they accurately describe the expected behaviour. The one inconsistency (the third case-insensitive entry being all-lowercase instead of following the mixed-domain pattern) is cosmetic and doesn't risk a false-positive or false-negative test result. tests/EmailTest.php — the third entry in the new proton.me case-insensitive group. Important Files Changed
Reviews (1): Last reviewed commit: "add proton mail case sensitiity test for..." | Re-trigger Greptile |
| ['MYMAIL777@PROTON.ME', 'mymail777@protonmail.com'], | ||
| ['MyMail777@Proton.Me', 'mymail777@protonmail.com'], | ||
| ['mymail777@proton.me', 'mymail777@protonmail.com'], |
There was a problem hiding this comment.
The third entry in this group is all-lowercase (
mymail777@proton.me), so it doesn't exercise any case normalisation — it is identical to the test added at line 564 in the regular block. Every other provider's three-entry group in this section follows the pattern UPPERCASE / MixedCase / lowercase-local+mixed-domain (e.g. user.name+tag@Protonmail.com). Using mymail777@Proton.Me as the third variant would stay consistent with that pattern and actually verify domain-case folding.
| ['MYMAIL777@PROTON.ME', 'mymail777@protonmail.com'], | |
| ['MyMail777@Proton.Me', 'mymail777@protonmail.com'], | |
| ['mymail777@proton.me', 'mymail777@protonmail.com'], | |
| ['MYMAIL777@PROTON.ME', 'mymail777@protonmail.com'], | |
| ['MyMail777@Proton.Me', 'mymail777@protonmail.com'], | |
| ['mymail777@Proton.Me', 'mymail777@protonmail.com'], |
No description provided.