Skip to content

Support domains 2.x #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChiragAgg5k merged 1 commit into from
May 13, 2026
Merged

Support domains 2.x #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"require": {
"php": ">=8.0",
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 PHP minimum version is now understated

composer.json declares php: ">=8.0", but the resolved dependency tree now requires PHP 8.3+: utopia-php/cache 2.1.0 specifies php: ">=8.3" and utopia-php/circuit-breaker 0.3.0 specifies php: ">=8.2". Any consumer (or CI matrix) still on PHP 8.0, 8.1, or 8.2 will hit a dependency resolution failure when installing this package, even though the declared constraint implies those versions are fine.

"utopia-php/validators": "0.*",
"utopia-php/domains": "^1.0"
"utopia-php/domains": "^2.0"
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Constraint drops 1.x support instead of adding 2.x alongside it

The PR description says "Allow utopia-php/domains 2.x alongside the existing 1.x range", but the change replaces ^1.0 with ^2.0, silently removing 1.x compatibility. Consumers currently pinned to ^1.0 will receive a conflict when they pull in this version of utopia-php/emails. If both major versions should be accepted, the constraint needs to be a union.

Suggested change
"utopia-php/domains": "^2.0"
"utopia-php/domains": "^1.0 || ^2.0"

},
"require-dev": {
"laravel/pint": "1.25.*",
Expand Down
Loading
Loading