v12- fix(forwarder): preserve HTTP/HTTPS integrations on config sync#2308
Merged
Kbayero merged 1 commit intoJul 1, 2026
Merged
Conversation
SyncCollectorConfig was deleting HTTP/HTTPS-only integrations (e.g. github) on every service restart because they are not present in ProtoPorts. Added a guard to skip deletion when the integration has an active HTTP or HTTPS entry, since those are managed by enable-integration / disable-integration.
🛑 AI review — Blocking issuesOne or more high/critical issues can break things and must be fixed before merging. Details below.
|
Kbayero
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SyncCollectorConfigwas deleting HTTP/HTTPS-only integrations (e.g.github)on every service restart because they are not present in
ProtoPorts.Why
HTTP integrations like
githublive only inHTTPPortsand are written tocfg.Integrations[key].HTTPSbyEnableHTTPIntegration. The sync loop checkedonly
ProtoPortsfor known keys, so on the next boot it treatedgithubasobsolete and removed it — silently losing the enabled integration.
Fix
Added a guard in the cleanup loop to skip deletion when the integration entry
has an active
HTTPorHTTPSpointer. Those entries are owned byenable-integration/disable-integrationand must not be touched by sync.