Skip to content

fix[installer](proxy): added upgrade header so ws connections can math between frontend and backend#2298

Open
AlexSanchez-bit wants to merge 3 commits into
release/v12.0.0from
backlog/v12_proxy_websocket_upgrade
Open

fix[installer](proxy): added upgrade header so ws connections can math between frontend and backend#2298
AlexSanchez-bit wants to merge 3 commits into
release/v12.0.0from
backlog/v12_proxy_websocket_upgrade

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Modification of installer templates affecting proxy configuration and WebSocket support.

  • high installer/templates/proxy.go:1 — Changes to installer templates require Tier 3 review as they impact infrastructure deployment and potential backwards compatibility for existing proxy setups.

🛑 bugs (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Duplicate map directive in Nginx configuration causes syntax error.

  • high installer/templates/proxy.go:57 — The 'map' directive is defined twice in the same configuration block (lines 1-4 and 57-60). Nginx configuration files do not allow duplicate 'map' blocks at the same scope; this will cause the Nginx service to fail to start.

🛑 security (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Modification of Nginx proxy configuration templates for the installer.

  • medium installer/templates/proxy.go:1 — The PR modifies the Nginx proxy configuration template used by the installer. Changes to infrastructure-as-code templates that handle proxying and header forwarding are security-critical as they impact request routing and potential header injection/manipulation.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant