fix(cisco-meraki): removed duplication of the or operator#2295
Open
JocLRojas wants to merge 1 commit into
Open
fix(cisco-meraki): removed duplication of the or operator#2295JocLRojas wants to merge 1 commit into
JocLRojas wants to merge 1 commit into
Conversation
❌ Go dependencies check failedThere are outdated Go dependencies, or modules that could not be inspected. Script output |
✅ AI review — ApprovedNo issues detected in this diff. ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed a duplicated
||operator in the CEL expression for the IPsec-SA eventactionResultstep in the Cisco Meraki filter.Reasoning
The duplicated
|| ||is invalid CEL syntax. This caused the add step to fail silently, meaning IPsec-SA events matching "established" would NOT have actionResult: accepted set. The fix removes the extra||so the CEL expression evaluates correctly and the field is populated as intended.Issue
N/A — typo caught during filter review.