Skip to content

fix(cisco-meraki): removed duplication of the or operator#2295

Open
JocLRojas wants to merge 1 commit into
v11from
hotfix/meraki-fix-duplicated-or
Open

fix(cisco-meraki): removed duplication of the or operator#2295
JocLRojas wants to merge 1 commit into
v11from
hotfix/meraki-fix-duplicated-or

Conversation

@JocLRojas

Copy link
Copy Markdown
Contributor

Changes

Fixed a duplicated || operator in the CEL expression for the IPsec-SA event actionResult step in the Cisco Meraki filter.

Reasoning

The duplicated || || is invalid CEL syntax. This caused the add step to fail silently, meaning IPsec-SA events matching "established" would NOT have actionResult: accepted set. The fix removes the extra || so the CEL expression evaluates correctly and the field is populated as intended.

Issue

N/A — typo caught during filter review.

@JocLRojas JocLRojas requested a review from a team June 29, 2026 21:11
@github-actions

Copy link
Copy Markdown

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./agent:
     - github.com/elastic/go-sysinfo: v1.15.4 → v1.15.5
     - gorm.io/gorm: v1.31.1 → v1.31.2

  📁 ./as400:
     - github.com/elastic/go-sysinfo: v1.15.4 → v1.15.5
     - gorm.io/gorm: v1.31.1 → v1.31.2

  📁 ./utmstack-collector:
     - github.com/elastic/go-sysinfo: v1.15.4 → v1.15.5
     - gorm.io/gorm: v1.31.1 → v1.31.2

  📁 ./installer:
     - github.com/cloudfoundry/gosigar: v1.3.121 → v1.3.122

  📁 ./plugins/gcp:
     - google.golang.org/api: v0.285.0 → v0.286.0

  📁 ./plugins/modules-config:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.25 → v1.32.26
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.24 → v1.19.25
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.77.0 → v1.78.1
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.43.3 → v1.43.4
     - google.golang.org/api: v0.285.0 → v0.286.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2/config: v1.32.25 → v1.32.26
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.24 → v1.19.25
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.77.0 → v1.78.1

  📁 ./agent-manager:
     - gorm.io/gorm: v1.31.1 → v1.31.2

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions

Copy link
Copy Markdown

✅ AI review — Approved

No issues detected in this diff.

architecture (gemini-3-flash-lite) — clean

Summary: No reviewable changes in this diff (excluded paths only).

No findings.

bugs (gemini-3-flash-lite) — clean

Summary: No reviewable changes in this diff (excluded paths only).

No findings.

security (gemini-3-flash-lite) — clean

Summary: No reviewable changes in this diff (excluded paths only).

No findings.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — Go dependencies check failed (see above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant