Distinguish between cases "resolver doesn't exist" and "resolver does exist, but fails" when resolving logical locations - #2901
Merged
Conversation
The new `tryResolve` is the same as the existing `safeResolve`, except `tryResolve` propagates both `IOException`s and unchecked exceptions to the caller, whereas `safeResolve` catches and ignores all exceptions.
…e *already* allows `IOException`s to be thrown (i.e., callers of those methods should already be sufficiently resilient)
sungshik
force-pushed
the
fix/1193-tryresolve-instead-of-saferesolve
branch
from
September 28, 2026 12:40
d5a8856 to
046db25
Compare
sungshik
commented
Sep 28, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
=======================================
Coverage 45% 45%
- Complexity 6799 6811 +12
=======================================
Files 843 844 +1
Lines 68828 68824 -4
Branches 10030 10028 -2
=======================================
+ Hits 31385 31420 +35
+ Misses 35054 35012 -42
- Partials 2389 2392 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sungshik
marked this pull request as ready for review
September 28, 2026 13:00
DavyLandman
requested changes
Sep 28, 2026
DavyLandman
left a comment
DavyLandman
left a comment
Member
There was a problem hiding this comment.
I think this PR is doing too little.
It should also be dealing with the case of a resolver that is not specific to an authority, but deal with case where it says to resolve all kinds of authorities, but sometimes fail.
The original issue with mkDirectory(|project://not-existing|) is a nice example of this. (but I understand that there are 2 project resolvers at play, and they make debugging/developing this feature messy)
DavyLandman
requested changes
Sep 30, 2026
DavyLandman
left a comment
DavyLandman
left a comment
Member
There was a problem hiding this comment.
Looks good, some small semantic/perf changes I propose.
…n resolution fails
DavyLandman
reviewed
Sep 30, 2026
DavyLandman
approved these changes
Sep 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes usethesource/rascal-language-servers#1193