Conversation
|
sungshik
changed the title
util::reflective::newRascalPomutil::reflective::pomXml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
=======================================
Coverage 45% 45%
- Complexity 6789 6792 +3
=======================================
Files 843 843
Lines 68798 68798
Branches 10029 10029
=======================================
+ Hits 31348 31352 +4
+ Misses 35064 35053 -11
- Partials 2386 2393 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sungshik
marked this pull request as ready for review
September 21, 2026 10:58
DavyLandman
requested changes
Sep 21, 2026
| private str getRascalMavenPluginVersion() { | ||
| try { // Best-effort attempt to get the latest version | ||
| loc l = |https://api.github.com/repos/usethesource/rascal-maven-plugin/releases/latest|; | ||
| if (/"tag_name":\s*"v<version:[0-9]+\.[0-9]+\.[0-9]+>"/ := readFile(l)) { |
Member
There was a problem hiding this comment.
We have a json parser in the stdlib, can we not use that? (And just use the raw value, not mapped onto a rascal ADT)
|
|
||
| private str getRascalMavenPluginVersion() { | ||
| try { // Best-effort attempt to get the latest version | ||
| loc l = |https://api.github.com/repos/usethesource/rascal-maven-plugin/releases/latest|; |
Member
There was a problem hiding this comment.
Either store this in a named global in this module, or online it?
| ' \</configuration\> | ||
| ' \<executions\> | ||
| ' \<execution\> | ||
| ' \<id\><name>-compile\</id\> |
Member
There was a problem hiding this comment.
It needs to be default-compile else it's not activated by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2880, #2881