Skip to content

Added a collect overload for constructor assignables. #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodinaarssen wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Added a collect overload for constructor assignables. #2886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/org/rascalmpl/compiler/lang/rascalcore/check/CollectStatement.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,9 @@ void collect(current:(Assignable) `<Assignable receiver> ? <Expression defaultEx
collect(receiver, defaultExpression, c);
}

// | constructor : Name name "(" {Assignable ","}+ arguments ")"
void collect(current:(Assignable) `<Name name> ( <{Assignable ","}+ arguments> )`, Collector c) {
collect(name, arguments, c);
}

void collect(current:(Assignable) `\< <{Assignable ","}+ elements> \>`, Collector c){
collect(elements, c);
Expand Down Expand Up @@ -1054,7 +1056,6 @@ set[str] getNames(Statement s) = {prettyPrintName(nm) | /QualifiedName nm := s};

private void checkAssignment(Statement current, constructor: (Assignable) `<Name name> ( <{Assignable ","}+ arguments> )` , str operator, Statement rhs, Collector c){
c.report(error(current, "Constructor assignable is not supported by the compiler"));
collect(name, arguments, c);

@DavyLandman DavyLandman Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed? we might still want to typecheck the expressions in there?

@rodinaarssen rodinaarssen Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved to the newly added collect overload

@DavyLandman DavyLandman Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but someone should still go into that part right? like name etc? or is this function never called?

@rodinaarssen rodinaarssen Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/usethesource/rascal/pull/2886/changes/BASE..6764ad27c85e319e6287c726dcecd63cb91919b9#diff-9060466303f8f0b8929cbe79c70ea73debbffd71f9bf892ba887946800a1cc30R624 dispatches both into the new collect and to this checkAssignment overload

@DavyLandman DavyLandman Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's just that the other checkAssignments seem to collect (but not all of them). So I'm trying to pattern match.

But I guess it's wiser to let @PaulKlint review this PR.

}

private void checkAssignment(Statement current, receiver: (Assignable) `\< <{Assignable ","}+ elements> \>`, str operator, Statement rhs, Collector c){
Expand Down
Loading