sirens: Improve Hook Compatibility#227
Merged
user-grinch merged 3 commits intouser-grinch:mainfrom Mar 31, 2026
Merged
Conversation
AmeerDotEXE
force-pushed
the
ameer/sirens-hooks
branch
from
ba6b822 to
2fd59fd
Compare
AmeerDotEXE
changed the title
hkRegisterCorona Hook
Contributor
Author
|
removed |
user-grinch
force-pushed
the
main
branch
2 times, most recently
from
c9bed73 to
da8bd07
Compare
Owner
|
Try with the latest changes. It should resolve the build issue. |
AmeerDotEXE
force-pushed
the
ameer/sirens-hooks
branch
from
2fd59fd to
fa0d86a
Compare
Contributor
Author
|
very nice :D |
Owner
|
Sorry but is it tested? (haven't been able to try it out yet) |
Contributor
Author
|
i haven't either, i don't have models to test with |
AmeerDotEXE
force-pushed
the
ameer/sirens-hooks
branch
from
fa0d86a to
7faa918
Compare
Contributor
Author
|
@user-grinch ready to merge, build succeeded and test passed 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes the assembly code in
hkRegisterCoronaand uses original call address for better mod compatiblility